Skip to content

Feature/nbs ingress chart#1317

Merged
EmmanuelNwa247 merged 6 commits intomainfrom
feature/nbs-ingress-chart
Mar 12, 2026
Merged

Feature/nbs ingress chart#1317
EmmanuelNwa247 merged 6 commits intomainfrom
feature/nbs-ingress-chart

Conversation

@EmmanuelNwa247
Copy link
Contributor

@EmmanuelNwa247 EmmanuelNwa247 commented Mar 10, 2026

Description

Adds a standalone nbs-ingress Helm chart that decouples all NBS7 ingress routing from the application charts. Supports both NGINX and Traefik ingress providers via feature flags (nginx.enabled / traefik.enabled), allowing STLTs to migrate to Traefik independently of their NBS7 application version. Also includes Traefik controller Helm values for AWS (EKS) and Azure (AKS) deployments.

Adds a separate nbs6-ingress Helm chart for CDC and Montana environments that run NBS6 (Classic/WildFly) in a container. This decouples the NBS6 ingress routing from the nbs6 application chart, supporting both NGINX and Traefik providers with the same flag pattern.

Creating a new Helm chart?

Yes — charts/nbs-ingress/ is a full Helm chart containing templates for all NBS7 ingress resources (main app routes, cached static assets, data ingestion, middlewares, and optional NiFi). charts/nbs6-ingress/ is a full Helm chart for NBS6 Classic ingress routing (main routes, cached static assets, and middlewares). charts/traefik/ contains only Helm values files used with the upstream traefik/traefik chart.

Notes

  • Replaces the embedded Traefik templates previously added to modernization-api and dataingestion-service — those templates have been removed and the traefikIngress.enabled values reset to false
  • Existing NGINX configuration in charts/nginx-ingress/ and existing Helm templates in application charts are unchanged
  • Image tag is managed by the chart's appVersion — not pinned in values files

@EmmanuelNwa247 EmmanuelNwa247 marked this pull request as ready for review March 10, 2026 20:05
@EmmanuelNwa247 EmmanuelNwa247 requested a review from a team March 10, 2026 20:05
Copy link
Contributor

@szamfir-skylight szamfir-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for this and for going back and forth when needed

cmansky
cmansky previously approved these changes Mar 12, 2026
Copy link
Contributor

@cmansky cmansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@szamfir-skylight szamfir-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate all the work!

@EmmanuelNwa247 EmmanuelNwa247 merged commit 5b767ec into main Mar 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants